spark404 edited a comment on issue #545: If there is no inMessage use the inFaultMessage URL: https://github.com/apache/cxf/pull/545#issuecomment-487928284 @coheigea Yes. I started out by making the tests fail in those unit tests. However I had to setup a pretty large amount of mocks and additional classes. To prove this you basically need to setup a complete entity reader that parses an input stream and eventually calls a method that was initialised wrongly with a null value. I managed to get quite far but the test looked more like a system test than a unit test. Thinking about it again i concluded that the actual fix should be that the initialisation of the ReaderInterceptorMBR should just not accept a null value as message. So that is that actual fix with a associated unittest. The other new unittest do indeed not trigger on this error because it happens downstream in other flow, still i wrote them anyway so they might be useful to have. Long story short, the proof is the null check in the ReaderInterceptorMBR. I would be interested in adding a system test to prove that the entire chain works as designed now, but i would ask for some pointers on where to start.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
