coheigea commented on a change in pull request #533: Drop @PreMatching - no need for it URL: https://github.com/apache/cxf/pull/533#discussion_r272128148
########## File path: rt/rs/security/http-signature/src/main/java/org/apache/cxf/rs/security/httpsignature/filters/VerifySignatureFilter.java ########## @@ -23,14 +23,12 @@ import javax.ws.rs.Priorities; import javax.ws.rs.container.ContainerRequestContext; import javax.ws.rs.container.ContainerRequestFilter; -import javax.ws.rs.container.PreMatching; import javax.ws.rs.ext.Provider; /** * RS CXF container Filter which extracts signature data from the context and sends it to the message verifier */ @Provider -@PreMatching Review comment: I think I'd prefer to keep it for the ContainerRequestFilter case - CXF does this for all of the other ContainerRequestFilter security implementations in JOSE, XML Security, etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
