reta commented on a change in pull request #462: Httpsig URL: https://github.com/apache/cxf/pull/462#discussion_r231751255
########## File path: rt/rs/security/http-signature/src/main/java/org/apache/cxf/rs/security/httpsignature/MessageVerifier.java ########## @@ -0,0 +1,242 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.cxf.rs.security.httpsignature; + +import java.nio.charset.StandardCharsets; +import java.security.Key; +import java.security.MessageDigest; +import java.security.NoSuchAlgorithmException; +import java.security.Security; +import java.util.*; +import java.util.logging.Logger; + +import org.apache.cxf.common.logging.LogUtils; +import org.tomitribe.auth.signatures.Signature; +import org.tomitribe.auth.signatures.Verifier; + + +public class MessageVerifier { + private static final Logger LOG = LogUtils.getL7dLogger(MessageVerifier.class); + + private AlgorithmProvider algorithmProvider; + private ExceptionHandler exceptionHandler; + private PublicKeyProvider publicKeyProvider; + private SecurityProvider securityProvider; + + private boolean verifyMessageBody; + + public MessageVerifier(boolean verifyMessageBody) { + this.exceptionHandler = (exception, type) -> new SignatureException("exception of type: " + type + " occurred"); + this.securityProvider = keyId -> Security.getProvider("SunRsaSign"); + this.algorithmProvider = keyId -> DefaultSignatureConstants.SIGNING_ALGORITHM; + this.verifyMessageBody = verifyMessageBody; + } + + public MessageVerifier(PublicKeyProvider publicKeyProvider, + ExceptionHandler exceptionHandler, + SecurityProvider securityProvider, + AlgorithmProvider algorithmProvider, + boolean verifyMessageBody) { + Objects.requireNonNull(publicKeyProvider, "Public key provider cannot be null"); Review comment: You probably meant `Objects.requireNonNull` for each argument, not only for `publicKeyProvider`, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
