reta commented on a change in pull request #369: [CXF-7610] - Adding SPI to
handle customizations to the server bean.
URL: https://github.com/apache/cxf/pull/369#discussion_r162786941
##########
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/ResourceUtils.java
##########
@@ -902,9 +904,18 @@ public static JAXRSServerFactoryBean
createApplication(Application app,
bean.getProperties(true).putAll(appProps);
}
bean.setApplication(app);
-
+ customize(bean);
return bean;
}
+
+ private static void customize(JAXRSServerFactoryBean bean) {
+ ServiceLoader<JAXRSServerFactoryCustomizationExtension> extensions
Review comment:
As I remember, the concern @johnament has about current implementation is
`JAXRSServerFactoryCustomizationExtension` being a CDI bean. If we re-implement
customization using events, we will still need a CDI bean to handle the event,
so from my perspective, not buying much.
Regarding the scope, I think we can limit it to CDI-only (essentially just
doing the service loader calls where they are needed, in CDI extension). I
believe it would address some of your concerns, @rmannibucau? I would also
prefer not to generalize it now because we don't have a real use case beyond
CDI actually. Or do you have, @johnament ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
