johnament commented on a change in pull request #369: [CXF-7610] - Adding SPI
to handle customizations to the server bean.
URL: https://github.com/apache/cxf/pull/369#discussion_r162784759
##########
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/ResourceUtils.java
##########
@@ -902,9 +904,18 @@ public static JAXRSServerFactoryBean
createApplication(Application app,
bean.getProperties(true).putAll(appProps);
}
bean.setApplication(app);
-
+ customize(bean);
return bean;
}
+
+ private static void customize(JAXRSServerFactoryBean bean) {
+ ServiceLoader<JAXRSServerFactoryCustomizationExtension> extensions
Review comment:
I dunno, don't forget that this is simply another way to automatically
discover resources. From the input I've received, it seems like we do almost
no automatic discovery (outside of CXF specific feature objects). Note that
I'm also not removing the CDI automatic extension loading, just adding to it
that `ServiceLoader` can be used, and that should be the default supported by
SSE (which is really where this all came from, the SSE JAR incorrect has a
`bean-discovery-mode=all` declared)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
