andymc12 commented on a change in pull request #366: Handle
ResponseExceptionMappers
URL: https://github.com/apache/cxf/pull/366#discussion_r161575313
##########
File path:
rt/rs/microprofile-client/src/main/java/org/apache/cxf/microprofile/client/MicroProfileClientProviderFactory.java
##########
@@ -91,18 +91,14 @@ protected void setProviders(boolean custom, boolean
busGlobal, Object... provide
public List<ResponseExceptionMapper<?>>
createResponseExceptionMapper(Message m, Class<?> paramType) {
- List<ResponseExceptionMapper<?>> candidates = new LinkedList<>();
-
- for (ProviderInfo<ResponseExceptionMapper<?>> em :
responseExceptionMappers) {
- if (handleMapper(em, paramType, m, ResponseExceptionMapper.class,
true)) {
- candidates.add(em.getProvider());
- }
- }
- if (candidates.size() == 0) {
+ if (responseExceptionMappers.isEmpty()) {
Review comment:
The only time where it would be empty would be if the user set the
`microprofile.rest.client.disable.default.mapper` property to true. In that
case we can avoid the sort code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
