johnament commented on a change in pull request #313: [CXF-7493] Add a default ClassUnwrapper for CDI integration. URL: https://github.com/apache/cxf/pull/313#discussion_r139439822
########## File path: integration/cdi/src/main/java/org/apache/cxf/cdi/CdiClassUnwrapper.java ########## @@ -0,0 +1,42 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.cxf.cdi; + +import java.util.List; +import static java.util.Arrays.asList; +import org.apache.cxf.common.util.ClassUnwrapper; + +class CdiClassUnwrapper implements ClassUnwrapper { + private static final List<String> UNWRAPPED_MARKERS = asList("OwbNormalScopeProxy", "WeldClientProxy"); Review comment: I have only seen the one suffix from OWB. Where can I find the list of suffixes? I saw what you did in TomEE, and I think using `$$` could be problematic for non-CDI frameworks, so I wanted to explicitly list out the known suffixes. I'm fine with putting something like this in core, and explicitly activating it in CDI, but would be concerned with being over eager with the swap out. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
