Github user andymc12 commented on a diff in the pull request:
https://github.com/apache/cxf/pull/301#discussion_r130893603
--- Diff:
rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/OutboundSseEventImpl.java ---
@@ -24,24 +24,24 @@
import javax.ws.rs.core.MediaType;
import javax.ws.rs.sse.OutboundSseEvent;
-public class OutboundSseEventImpl implements OutboundSseEvent {
- private String id;
- private String name;
- private String comment;
- private long reconnectDelay = -1;
- private Class<?> type;
- private Type genericType;
- private MediaType mediaType;
- private Object data;
+public final class OutboundSseEventImpl implements OutboundSseEvent {
+ private final String id;
+ private final String name;
+ private final String comment;
+ private final long reconnectDelay;
+ private final Class<?> type;
+ private final Type genericType;
+ private final MediaType mediaType;
+ private final Object data;
public static class BuilderImpl implements Builder {
private String id;
private String name;
private String comment;
private long reconnectDelay = -1;
- private Class<?> type;
+ private Class<?> type = String.class;
--- End diff --
Hmm... I must've been looking at an older version of the javadoc. It looks
like there is no `data(String s)` method - it was changed to `data(Object o)`.
I'll change the code to use the type of the passed-in object if the class is
not specified by the user.
Thanks again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
