On Tuesday, January 03, 2012 12:45:42 PM Benson Margulies wrote: > So I apparently busted some things in the codegen plugin for 2.5.1. > Unfortunately, I've been sick for a week, and that really puts a chomp > into my ability to roll my sleeves up. My strong belief is that we > need proper plugin integration tests, the same way that other maven > plugins deal with this -- the maven-invoker-plugin.
+1 > Has anyone else > got time to start on this? If not, I'll get onto it when I can. I've never looked into using the maven-invoker-plugin to run it tests. I was going to grab olamy to help walk me through it, but he ended up having an additional child suddenly appear yesterday and is now on full time "daddy duty" for a bit. :-) (congrats to him, btw) I may have some time next week, but right now, no. That said, I just looked at the issues and the issues are all due to the exact same issue and I'm testing a fix for it now. Basically, the defaultOptions were being merged in twice in SOME cases. In the directory scan, it used the defaultOptions to initialize the options, but then a merge was done in mergeOptions and the extraArgs would get doubled. I ended up taking out the passing of the defaultOptions into the various scans and such and letting just the mergeOptions call handle it. That allows it to work for the scan, the explicitly set stuff, and the wsdl dep case. -- Daniel Kulp [email protected] - http://dankulp.com/blog Talend Community Coder - http://coders.talend.com
