Hi, Thanks Daniel for a fix. Looks fine - error dialog works without issue.
On Fri, Feb 4, 2011 at 10:54 PM, Daniel Kulp <dk...@apache.org> wrote: > On Friday 04 February 2011 4:29:12 pm Daniel Kulp wrote: >> On Friday 04 February 2011 4:24:39 pm Sergey Beryozkin wrote: >> > Tomasz, I had to comment out few lines in the rt/management-web/pom.xml >> > (excluded the browser package from the compilation). >> > >> > I won't have time in the next couple of weeks to push the browser >> > subpackage to a subproject, so for a while I suggest >> > we work on it in our own snapshots, and then, before committing the >> > changes we exclude the browser subpackage in the pom.xml. >> >> The only problematic class is the ErrorDialog. Is there a way to get that >> reworked to not use the extgui stuff? That would fix the issue just >> fine. > > I've gone ahead and made ErrorDialog just extend PopUp for now. I'm really > not sure what that will do, but it at least now compiles and such. > > Dan > > > >> Dan >> >> > thanks, Sergey >> > >> > On Fri, Feb 4, 2011 at 5:55 PM, Sergey Beryozkin >> >> <sberyoz...@gmail.com>wrote: >> > > Hi all, >> > > >> > > I have just moved the LogBrowser project Tomasz was working upon as >> > > part of GSOC 2010 to the trunk. I've done few minor changes before >> > > moving it in. >> > > >> > > - rt/management-web has a new package, >> > > org.apache.cxf.management.web.browser* which contains the code for the >> > > browser. It was org.apache.cxf.management.web.logging.logbrowser* in >> > > the sandbox but I thought we might enhance it in the future to work >> > > PersistingIn/Out interceptors in the rt/management so decided to >> > > simplify the package name. >> > > >> > > - samples/logbrowser is the demo showing the LogBrowser in action. >> > > >> > > It may make sense even move the whole rt/management-web into a CXF >> > > subproject, we'll see. For now, I'd like to have the browser polished >> > > and then we can decide. >> > > >> > > The GWT compilation will happen as part of building the >> > > rt/management-web, so the final jar will actually have the generated >> > > GWT code and resources included. We may consider doing it during the >> > > demo run, but again, lets try to polish the browser first. >> > > >> > > Tomasz, first of all congrats, I think it is good that your project is >> > > moving to the trunk. >> > > I'd appreciate if you could help me a bit with the initial clean-up, >> > > hope you'll find some time. You are a CXF committer now so you can do >> > > changes on the trunk... >> > > >> > > Here is the initial list of issues which I need some help with : >> > > >> > > 1. LogBrowser has a showstopper bug which I'm sure is due to the fact >> > > we just did not look at it for a while :-). Basically, when I go and >> > > generate the logs, and then click 'refresh' on the endpoint, the >> > > browser reports an exception. >> > > The AtomPullServer is functioning ok, Firefox subscribes to the Atom >> > > Feed with no probs. >> > > >> > > 2. Please move ManageEndpoints button either immediately above or below >> > > the Filter button >> > > >> > > 3. Remove the Tasks and Endpoints buttons/entries, lets have it the way >> > > you did it originally. We only need to see the list of endpoints which >> > > will be added via "ManageEndpoints", the explorer style is just too >> > > complex. >> > > >> > > 4. When I go to ManageEndpoints, "Sign Out" leaks into the new panel >> > > and overlaps with the "Settings" entry, >> > > >> > > 5. In ManageEndpoints please change "back to browse" to "Back to >> > > Explorer" >> > > >> > > >> > > 6. We will need to think what to do with the jscript library added to >> > > the demo - we will have to link to its via remore URI or simple do a >> > > simpler plain HTML form - not a priority right now. >> > > >> > > Hope it's not a big list :-). We will catch up on the GWT dev a bit and >> > > I also hope other users with the GWT experience contribute in time. >> > > What I will do before 2.4 is look at the browser code and see what I >> > > can refactor but also add some helpers to the AtomPullServer so that >> > > users can use it for reading from the existing file logs... >> > > >> > > Thanks, Sergey > > -- > Daniel Kulp > dk...@apache.org > http://dankulp.com/blog > -- Best regards, Tomasz Oponowicz
