No probs :-), I can take care of minimizing the duplicate code thanks, Sergey
On Thu, Nov 11, 2010 at 11:15 AM, Glen Mazza <glen.ma...@gmail.com> wrote: > > Sorry, my bad, I did not realize they were actually different tests, I will > revert them. > > Glen > > > Sergey Beryozkin-5 wrote: > > > > Hi Glen > > > > thanks for trying to clean up the tests, but I'd actually like them > > retained, but I agree some code optimization needs to be done though, > > please > > note, the tests you have removed use *CONFIG2* which has a slightly > > different conduit configuration. > > > > So we just can have a doTest...(String configFile) and both tests will > > just > > delegate to this utility code > > > > cheers, SErgey > > > > On Wed, Nov 10, 2010 at 3:43 PM, <gma...@apache.org> wrote: > > > >> Author: gmazza > >> Date: Wed Nov 10 15:43:25 2010 > >> New Revision: 1033532 > >> > >> URL: http://svn.apache.org/viewvc?rev=1033532&view=rev > >> Log: > >> Removed duplicate test. > >> > >> Modified: > >> > >> > >> > cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/security/JAXRSHttpsBookTest.java > >> > >> Modified: > >> > cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/security/JAXRSHttpsBookTest.java > >> URL: > >> > http://svn.apache.org/viewvc/cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/security/JAXRSHttpsBookTest.java?rev=1033532&r1=1033531&r2=1033532&view=diff > >> > >> > ============================================================================== > >> --- > >> > cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/security/JAXRSHttpsBookTest.java > >> (original) > >> +++ > >> > cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/security/JAXRSHttpsBookTest.java > >> Wed Nov 10 15:43:25 2010 > >> @@ -58,20 +58,6 @@ public class JAXRSHttpsBookTest extends > >> } > >> > >> @Test > >> - public void testGetBook123ProxyWithURLConduitId() throws Exception > { > >> - > >> - BookStore bs = JAXRSClientFactory.create("https://localhost:"; > + > >> PORT, BookStore.class, > >> - CLIENT_CONFIG_FILE2); > >> - // just to verify the interface call goes through CGLIB proxy > >> too > >> - assertEquals("https://localhost:"; + PORT, > >> WebClient.client(bs).getBaseURI().toString()); > >> - Book b = bs.getSecureBook("123"); > >> - assertEquals(b.getId(), 123); > >> - b = bs.getSecureBook("123"); > >> - assertEquals(b.getId(), 123); > >> - } > >> - > >> - > >> - @Test > >> public void testGetBook123ProxyToWebClient() throws Exception { > >> > >> BookStore bs = JAXRSClientFactory.create("https://localhost:"; + > >> PORT, BookStore.class, > >> > >> > >> > > > > > > -- > View this message in context: > http://cxf.547215.n5.nabble.com/Re-svn-commit-r1033532-cxf-trunk-systests-jaxrs-src-test-java-org-apache-cxf-systest-jaxrs-security-a-tp3258888p3260076.html > Sent from the cxf-dev mailing list archive at Nabble.com. >
