Hi Sergey,

Referring to commit r981073, I introduce as fallows changes (include
your comments):

- Added word wrap to entry content;
- Added fancy exception handler;
- Hided security fields in "add/edit endpoint" dialog box;
- Added Customer service and client (for easy interact) to sample -
service produces log entries which simulate using LogBrowser in
production environment;
- Updated default AtomPullServer's pageSize from 40 to 25;
- Added restoring entry selection when change page;
- Added validation for "Copies" fiels in sample;
- Added support for arrows in entries list;
- Replace cutting message with "title" property;
- Added milliseconds to datetime format;
- Fixed clearing entries list - added removing all cells rather than
clearing content;
- Added validation for "name" and "url" in "add/edit endpoint" dialog box;

I think all issues and missing features has been resolved. If you mind
I'll come back to refactoring, adding documentation etc.

Below I gather all your previous comments, which has been resolved in
last commit:

On Thu, Jul 29, 2010 at 1:38 PM, Sergey Beryozkin <sberyoz...@gmail.com> wrote:
>> However I also found issues (I will fix them ASAP):
>>
>> - Hide security fields (username, password etc) in "Add/Edit endpoint"
>> dialog box (because I won't implemented authentication for endpoints
>> in the near future,)
>> - Add more advanced exception handler for easy investigating exception;
>> - Add word wrap to entry content;

Done.

>> > - the log entry content does not show now date/level but it has some
>> > prefixes which I'm not sure about, ex, if the log entry in the list in
>> the
>> > top right corner reads DEBUG SomeTime "1" then what is displayed below id
>> > "[12]1", so no level & time but some bogus "[12]" prefix

Done.

>> > - GenerateServlet still causes issues for me, had to enter 40 entries 1 by 
>> > 1

Fixed - it should work without any problem, but to make sure I add
numbers only ability to input and fail fast when can't parse number in
GenerateServlet.

>> >  but rather introduce a JAXRS app
>> > endpoint which generates some custom log entries and have the browser
>> > involking on that endpoint as discussed earlier on.

Done.

>> > - Update AtomPullServer to have say a 20-25 limit per page by default - I
>> > put 40 originally but it is too much..

Done.

>> > - Key Focus is lost periodically. Example, I have to select an individual
>> > log entry in the top right corner. But it has to be selected once I
>> select
>> > TestEndpoint in the left pane (if the entries already exist) or after
>> > Refresh and the focus should stay there on that initial entry. If I now
>> > press 'next' I should see the first entry in the next list selected again
>> > and the same should happen when I press previous. May be this is not easy

Done.

>> If possible :-) It would also be nice to be able to browse using just
> keyboard (using up and down arrows) - but it would be an additional
> enhancement

Done.

-- 
Best regards,
Tomasz Oponowicz

Reply via email to