Hi Richard, Thanks for the initial PR. I had a look at the PR and the changes look good with regards to SLF4J. However, the versionRange in root POM could introduce unpredictability in builds if newer versions introduce breaking changes
On Sat, 27 Jul 2024 at 06:06, Richard Eckart de Castilho <r...@apache.org> wrote: > Hi Sean, > > i have set up an initial PR here: > > https://github.com/apache/ctakes/pull/21 > > However, there are a few issues: > > - The lifecycle plugin in the root POM uses "version" instead of > "versionRange" in the main branch - the PR fixes that > - The main branch still uses ContextSingletonBeanFactoryLocator which is > not part of Spring anymore and thus the Eclipse has compiler errors > - Many calls to the logging use String.format or similar means to > construct the logged string. This can be done better using the SLF4J API, > e.g. `debug("{} is less than {}", x, y)` or `error("This is an error, > ex)`. I did not upgrade all these calls. > - I commented out some calls to directly configure the logging system - > instead there should be `log4j2-test.xml` files or similar > configuration files for slf4j-simple used for testing. > - Calls to SLF4J in UIMA components should be replaced by > `getLogger().xxxx` - I did this in some cases > - It would IMHO be a good idea to introduce the maven-dependency-plugin to > ensure that all packages used have direct non-transitive > Maven dependencies and there are no unused dependencies > > Cheers, > > -- Richard > > -- Regards, Gandhi "The best way to find urself is to lose urself in the service of others !!!"
