Hey Mike,
As mentioned on IRC I'd like to see some test cases in our suite
to help ensure we don't regress on this in the future. Specifically,
I think it'd be good to ensure consistent revs on a handful of
indicative docs.
There's nothing saying we can't change how we do this in the future,
but we need to be mindful of the fact now that:
1) We are a reference implementation for rev calculation for other DBs,
and
2) We should be alerted to the fact that how we calculate revs for docs
has changed due to some checkin or another
You mentioned on IRC you had a few documents that could help with this.
Even if you don't commit the test cases yourself, could you share your
current test suite with us somehow?
Thanks,
Joan
----- Original Message -----
> From: "Michael Fair" <mich...@daclubhouse.net>
> To: dev@couchdb.apache.org
> Sent: Saturday, March 26, 2016 7:49:21 PM
> Subject: Re: Calculating Revision IDs outside erlang (proposal to add
> {minor_version, 1} to the calc)
>
> Alright, merge is in!
>
> Step 1) for 2.0+ revisions!
>
> Thanks all!
> Mike
> On Mar 24, 2016 12:16 AM, "Michael Fair" <mich...@daclubhouse.net>
> wrote:
>
> > Ok pull request is away, I used the GitHub repository,
> > apache/master as a
> > base, and revId-minor_version_1-md5Calc as the branch in my fork.
> > It
> > wasn't obvious to me how to get a Jira ticket and branch created
> > and my git
> > skills are minimal on a good day.
> >
> > There was a build error on R16B03-1; I tried to look at the logs
> > but
> > wasn't sure what I was looking at/for.
> >
> > The actual change is extremely minimal as it's just changing like
> > 876 in
> > src/couch_db.erl from this:
> > couch_crypto:hash(md5, term_to_binary([Deleted,
> > OldStart,
> > OldRev, Body, Atts2]))
> >
> > to this:
> > couch_crypto:hash(md5, term_to_binary([Deleted,
> > OldStart,
> > OldRev, Body, Atts2], [{minor_version, 1}]))
> >
> > Any advice/help/guidance appreciated.
> >
> > Thanks,
> > Mike
> >
>
