Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/317#discussion_r27959286
--- Diff: app/addons/activetasks/tests/activetasks.storesSpec.js ---
@@ -0,0 +1,231 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+// use this file except in compliance with the License. You may obtain a
copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations
under
+// the License.
+define([
+ 'api',
+ 'addons/activetasks/views',
+ 'addons/activetasks/resources',
+ 'addons/activetasks/components.react',
+ 'addons/activetasks/stores',
+ 'addons/activetasks/tests/fakeActiveTaskResponse',
+ 'react',
+ 'testUtils'
+], function (FauxtonAPI, Views, ActiveTasks, Components, Stores,
fakedResponse, React, testUtils) {
+ var assert = testUtils.assert;
+ var TestUtils = React.addons.TestUtils;
+
+ var activeTasksStore = Stores.activeTasksStore;
+ var activeTasksCollection = new ActiveTasks.AllTasks();
+ activeTasksCollection.parse(fakedResponse);
+
+ describe('Active Tasks -- Stores', function () {
+ var spy;
+
+ beforeEach(function () {
+ activeTasksStore.init(activeTasksCollection.table,
activeTasksCollection);
+ this.clock = sinon.useFakeTimers();
+ });
+
+ afterEach(function () {
+ spy.restore();
+ this.clock.restore();
+ });
+
+ describe('Active Task Stores - Polling', function () {
+ var pollingWidgetDiv, pollingWidget;
+
+ it('should poll at the min time', function () {
+ spy = sinon.spy(activeTasksStore, 'getPollingInterval');
+ var minTime = 1;
+ activeTasksStore.setPollingInterval(minTime);
+ activeTasksStore.setPolling();
+ assert.ok(spy.calledOnce);
+
+ setInterval(spy, minTime * 1000);
+ this.clock.tick(minTime * 1000);
+ assert.ok(spy.calledTwice);
+
+ this.clock.tick(minTime * 1000);
+ assert.ok(spy.calledThrice);
+ });
+
+ it('should poll at the max time', function () {
+ spy = sinon.spy(activeTasksStore, 'getPollingInterval');
+
+ var maxTime = 30;
+ activeTasksStore.setPollingInterval(maxTime);
+ activeTasksStore.setPolling();
+ assert.ok(spy.calledOnce);
+
+ setInterval(spy, maxTime * 1000);
+ this.clock.tick(maxTime * 1000);
+ assert.ok(spy.calledTwice);
+
+ this.clock.tick(maxTime * 1000);
+ assert.ok(spy.calledThrice);
+ });
+
+ it('should poll at a mid time', function () {
+ spy = sinon.spy(activeTasksStore, 'getPollingInterval');
+
+ var midtime = 15;
+ activeTasksStore.setPollingInterval(midtime);
+ activeTasksStore.setPolling();
+ assert.ok(spy.calledOnce);
+
+ setInterval(spy, midtime * 1000);
+ this.clock.tick(midtime * 1000);
+ assert.ok(spy.calledTwice);
+
+ this.clock.tick(midtime * 1000);
+ assert.ok(spy.calledThrice);
+ });
+
+ it('should clear interval each time', function () {
+ var spy = sinon.spy(window, 'clearInterval');
+ activeTasksStore.setPolling();
+ assert.ok(spy.calledOnce);
+ });
+ });
+
+ describe('Active Task Stores - Filter Tab Tray', function () {
+ var fakeFilteredTable, storeFilteredtable;
+ function sort (a, b, sortBy) { //sorts array by objects with key
'sortBy', with default started_on
+ if (_.isUndefined(sortBy)) {
+ sortBy = 'started_on';
+ }
+ return b[sortBy] - a[sortBy];
+ }
+
+ afterEach(function () {
+ fakeFilteredTable = [];
+ });
+
+ it('should filter the table correctly, by radio -- All Tasks',
function () {
+ activeTasksStore.setSelectedRadio('all_tasks');
+ //parse table and check that it only contains objects any type
+ var table =
activeTasksStore.getFilteredTable(activeTasksStore._collection);
+ assert.ok(activeTasksStore._collection.length, table.length);
+ });
+
+ it('should filter the table correctly, by radio -- Replication',
function () {
+ activeTasksStore.setSelectedRadio('replication');
+ var storeFilteredtable =
activeTasksStore.getFilteredTable(activeTasksStore._collection);
+
+ //parse table and check that it only contains objects with type:
Replication
+ _.each(storeFilteredtable, function (activeTask) {
+ assert.ok(activeTasksStore.passesRadioFilter(activeTask));
+ assert.ok(activeTask.type ===
activeTasksStore.getSelectedRadio());
+ });
+
+ //check that the other tasks from collection do not have type:
Replication
+ fakeFilteredTable = _.filter(activeTasksCollection.table, function
(task) {
+ return task.type === 'replication';
+ });
+ assert.deepEqual(fakeFilteredTable.sort(sort),
storeFilteredtable.sort(sort));
+ });
+
+ it('should filter the table correctly, by radio -- Database
Compaction', function () {
+ activeTasksStore.setSelectedRadio('database_compaction');
+ var storeFilteredtable =
activeTasksStore.getFilteredTable(activeTasksStore._collection);
+
+ //parse table and check that it only contains objects with type:
database_compaction
+ _.each(storeFilteredtable, function (activeTask) {
+ assert.ok(activeTasksStore.passesRadioFilter(activeTask));
+ assert.ok(activeTask.type ===
activeTasksStore.getSelectedRadio());
+ });
+
+ //check that the other tasks from collection do not have type:
database_compaction
+ fakeFilteredTable = _.filter(activeTasksCollection.table, function
(task) {
+ return task.type === 'database_compaction';
+ });
+ assert.deepEqual(fakeFilteredTable.sort(sort),
storeFilteredtable.sort(sort));
+ });
+
+ it('should filter the table correctly, by radio -- Indexer',
function () {
+ activeTasksStore.setSelectedRadio('indexer');
+ var storeFilteredtable =
activeTasksStore.getFilteredTable(activeTasksStore._collection);
+
+ //parse table and check that it only contains objects with type:
indexer
+ _.each(storeFilteredtable, function (activeTask) {
+ assert.ok(activeTasksStore.passesRadioFilter(activeTask));
+ assert.ok(activeTask.type ===
activeTasksStore.getSelectedRadio());
+ });
+
+ //check that the other tasks from collection do not have type:
indexer
+ fakeFilteredTable = _.filter(activeTasksCollection.table, function
(task) {
+ return task.type === 'indexer';
+ });
+ assert.deepEqual(fakeFilteredTable.sort(sort),
storeFilteredtable.sort(sort));
+ });
+
+ it('should filter the table correctly, by radio -- View Compaction',
function () {
+ activeTasksStore.setSelectedRadio('view_compaction');
+ var storeFilteredtable =
activeTasksStore.getFilteredTable(activeTasksStore._collection);
+
+ //parse table and check that it only contains objects with type:
view_compaction
+ _.each(storeFilteredtable, function (activeTask) {
+ assert.ok(activeTasksStore.passesRadioFilter(activeTask));
+ assert.ok(activeTask.type ===
activeTasksStore.getSelectedRadio());
+ });
+
+ //check that the other tasks from collection do not have type:
view_compaction
+ fakeFilteredTable = _.filter(activeTasksCollection.table, function
(task) {
+ return task.type === 'view_compaction';
+ });
+ assert.deepEqual(fakeFilteredTable.sort(sort),
storeFilteredtable.sort(sort));
+ });
+
+ it('should search the table correctly', function () {
+ activeTasksStore.setSelectedRadio('all_tasks');
+ var searchTerm = 'base';
+ activeTasksStore.setSearchTerm(searchTerm);
+ var storeGeneratedTable =
activeTasksStore.getFilteredTable(activeTasksStore._collection);
--- End diff --
Instead of generating a take filterered table. Rather just create a table
with the required results. Then check that the store can generate the same
results. It will greatly simplify the test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
