Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/10#discussion_r21099269
--- Diff: test/chttpd_handler_reload_test.erl ---
@@ -0,0 +1,111 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you
may not
+% use this file except in compliance with the License. You may obtain a
copy of
+% the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
software
+% distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the
+% License for the specific language governing permissions and limitations
under
+% the License.
+
+-module(chttpd_handler_reload_test).
+
+-compile(export_all).
+
+-include_lib("eunit/include/eunit.hrl").
+
+%% for testing
+
+a() -> a.
+b() -> b.
+c() -> c.
+d() -> d.
+e() -> e.
+f() -> f.
+g() -> g.
+h() -> h.
+
+-spec reload_test() -> ok.
+%% @doc verifies that there are no side effects from prior builds.
+reload_test() ->
--- End diff --
The value in splitting this out is that we will know the full pass/fail
matrix for each of the tests. Keeping them together like this means we'll only
know the first failure. I think that's a useful change if it doesn't make the
test too much more complicated. I don't think it's *required* to split these
out given how unlikely breaking one (but not all) is, so I'm +1 on this test as
it stands and +1 on improving it if possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
