Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/233#discussion_r12772184
  
    --- Diff: src/couchdb/couch_httpd_misc_handlers.erl ---
    @@ -79,6 +80,15 @@ handle_utils_dir_req(#httpd{method='GET'}=Req, 
DocumentRoot) ->
     handle_utils_dir_req(Req, _) ->
         send_method_not_allowed(Req, "GET,HEAD").
     
    +maybe_add_csp_headers(Headers, "false") ->
    +    Headers;
    +maybe_add_csp_headers(Headers, "true") ->
    +    DefaultValues = "default-src 'self'; img-src *; font-src *; " ++
    --- End diff --
    
    Why not to replace all these with just `allow 'self';` ? Looks good and 
solid default behaviour. Is there any need in external images, fonts, unsafe 
arbitrary code execution and style inline (you may inline style with JS code to 
overrun XSS policy)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to