This appears to be fixed, passes for me everywhere.

Wendall

On 04/29/2014 06:55 AM, Alexander Shorin wrote:
Issue with 231-cors.t is fixed
https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=0bb567f
--
,,,^..^,,,


On Tue, Apr 29, 2014 at 5:16 PM, Alexander Shorin <[email protected]> wrote:
On Tue, Apr 29, 2014 at 5:06 PM, Alexander Shorin <[email protected]> wrote:
On Tue, Apr 29, 2014 at 5:01 PM, Alexander Shorin <[email protected]> wrote:
On Sat, Apr 19, 2014 at 2:03 AM, Mutton, James <[email protected]> wrote:
R14B04
Sigs: OK
Hashes: OK
../test/etap/231-cors.t                          (Wstat: 0 Tests: 27 Failed: 1)
   Failed test:  27
   Parse errors: Bad plan.  You planned 26 tests but ran 27.
Files=51, Tests=1213, 309 wallclock secs ( 0.46 usr  0.11 sys + 139.07 cusr 
19.59 csys = 159.23 CPU)
Result: FAIL
Install/Run: OK
Verify: OK
Reproduced on Gentoo and FreeBSD with R14B04. That's gonna be funny.
$ ./test/etap/run -v ./test/etap/231-cors.t
[17:04:39] ▸▸▸▸▸▸▸▸▸▸
./test/etap/231-cors.t ..
./test/etap/231-cors.t:429: Warning: variable 'Else' is unused
# Current time local 2014-04-29 17:04:44
# Using etap version "0.3.4"
1..26
Apache CouchDB 0.0.0 (LogLevel=info) is starting.
Apache CouchDB has started. Time to relax.
[info] [<0.2.0>] Apache CouchDB has started on http://127.0.0.1:24981/
[info] [<0.88.0>] 127.0.0.1 - - GET / 200
ok 1  - No CORS Headers when disabled
[info] [<0.89.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 2  - No CORS Headers when disabled
[info] [<0.90.0>] 127.0.0.1 - - GET / 200
ok 3  - Specified invalid origin, no Access
[info] [<0.91.0>] 127.0.0.1 - - OPTIONS / 405
ok 4  - invalid origin
[info] [<0.92.0>] 127.0.0.1 - - OPTIONS / 204
ok 5  - test_preflight_request Access-Control-Allow-Methods ok
[info] [<0.93.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 6  - db Access-Control-Allow-Origin ok
ok 7  - db Access-Control-Expose-Headers ok
[info] [<0.94.0>] 127.0.0.1 - - PUT /etap-test-db/doc1/attachment.txt 201
[info] [<0.95.0>] 127.0.0.1 - - GET /etap-test-db/doc1?attachments=true 200
ok 8  - Response without errors
[info] [<0.96.0>] 127.0.0.1 - - PUT /etap-test-db/doc2/attachment.bin 201
[info] [<0.97.0>] 127.0.0.1 - - GET /etap-test-db/doc2/attachment.bin 206
ok 9  - Response without errors
[info] [<0.88.0>] 127.0.0.1 - - OPTIONS /etap-test-db 204
ok 10  - db Access-Control-Allow-Methods ok
[info] [<0.88.0>] 127.0.0.1 - - GET /etap-test-db1 200
ok 11  - db origin ok
[info] [<0.88.0>] 127.0.0.1 - - OPTIONS / 405
ok 12  - check non defined host:port in origin ok
[info] [<0.88.0>] 127.0.0.1 - - OPTIONS / 405
ok 13  - check non defined scheme in origin ok
[info] [<0.88.0>] 127.0.0.1 - - GET /etap-test-db/doc2 200
[info] [<0.88.0>] 127.0.0.1 - - GET /etap-test-db/doc2 304
ok 14  - Responded with Not Modified
[info] [<0.88.0>] 127.0.0.1 - - OPTIONS / 204
ok 15  - check host:port in origin ok
[info] [<0.88.0>] 127.0.0.1 - - OPTIONS / 204
ok 16  - check scheme in origin ok
[info] [<0.88.0>] 127.0.0.1 - - OPTIONS / 204
ok 17  - db origin ok
[info] [<0.88.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 18  - db access config case mismatch
[info] [<0.88.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 19  - db Access-Control-Allow-Credentials off
[info] [<0.88.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 20  - db Access-Control-Allow-Credentials ok
[info] [<0.88.0>] 127.0.0.1 - - OPTIONS / 204
ok 21  - test_preflight_request Access-Control-Allow-Methods ok
[info] [<0.88.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 22  - db Access-Control-Allow-Origin ok
ok 23  - db Access-Control-Expose-Headers ok
[info] [<0.88.0>] 127.0.0.1 - - OPTIONS /etap-test-db 204
ok 24  - db Access-Control-Allow-Methods ok
[info] [<0.88.0>] 127.0.0.1 - - GET /etap-test-db1 200
ok 25  - db origin ok
[info] [<0.88.0>] 127.0.0.1 - - OPTIONS / 405
ok 26  - check non defined host:port in origin ok
[info] [<0.88.0>] 127.0.0.1 - - OPTIONS / 405
ok 27  - check non defined scheme in origin ok
# Test died abnormally: {'EXIT',
                           {function_clause,
                               [{couch_passwords,hash_admin_password,["test"]},
                                {erl_eval,do_apply,5},
                                {erl_eval,expr,5},
                                {escript,eval_exprs,5},
                                {erl_eval,local_func,5},
                                {erl_eval,expr,5},
                                {escript,eval_exprs,5},
                                {erl_eval,local_func,5}]}}
[error] [<0.31.0>] {error_report,<0.23.0>,
                     {<0.31.0>,crash_report,
                      [[{initial_call,{etap,start_etap_server,[]}},
                        {pid,<0.31.0>},
                        {registered_name,etap_server},
                        {error_info,
                         {error,badarg,
                          [{io,format,
                            [<0.23.0>,"~s~n",
                             [[66,97,105,108,32,111,117,116,33,32|
                               {'EXIT',
                                {function_clause,
                                 [{couch_passwords,hash_admin_password,
                                   ["test"]},
                                  {erl_eval,do_apply,5},
                                  {erl_eval,expr,5},
                                  {escript,eval_exprs,5},
                                  {erl_eval,local_func,5},
                                  {erl_eval,expr,5},
                                  {escript,eval_exprs,5},
                                  {erl_eval,local_func,5}]}}]]]},
                           {etap,test_server,1},
                           {proc_lib,init_p_do_apply,3}]}},
                        {ancestors,[<0.2.0>]},
                        {messages,[done]},
                        {links,[]},
                        {dictionary,[]},
                        {trap_exit,false},
                        {status,running},
                        {heap_size,2584},
                        {stack_size,24},
                        {reductions,1177}],
                       []]}}
All 26 subtests passed
Oh..run the same on R17, twice (but still reproducible from time to time):

couchdb $ ./test/etap/run -v ./test/etap/231-cors.t
./test/etap/231-cors.t ..
./test/etap/231-cors.t:429: Warning: variable 'Else' is unused
# Current time local 2014-04-29 13:11:52
# Using etap version "0.3.4"
1..26
Apache CouchDB 0.0.0 (LogLevel=info) is starting.
Apache CouchDB has started. Time to relax.
[info] [<0.2.0>] Apache CouchDB has started on http://127.0.0.1:44066/
[info] [<0.65.0>] 127.0.0.1 - - GET / 200
ok 1  - No CORS Headers when disabled
[info] [<0.66.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 2  - No CORS Headers when disabled
[info] [<0.67.0>] 127.0.0.1 - - GET / 200
ok 3  - Specified invalid origin, no Access
[info] [<0.68.0>] 127.0.0.1 - - OPTIONS / 405
ok 4  - invalid origin
[info] [<0.69.0>] 127.0.0.1 - - OPTIONS / 204
ok 5  - test_preflight_request Access-Control-Allow-Methods ok
[info] [<0.70.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 6  - db Access-Control-Allow-Origin ok
ok 7  - db Access-Control-Expose-Headers ok
[info] [<0.71.0>] 127.0.0.1 - - PUT /etap-test-db/doc1/attachment.txt 201
[info] [<0.72.0>] 127.0.0.1 - - GET /etap-test-db/doc1?attachments=true 200
ok 8  - Response without errors
[info] [<0.73.0>] 127.0.0.1 - - PUT /etap-test-db/doc2/attachment.bin 201
[info] [<0.74.0>] 127.0.0.1 - - GET /etap-test-db/doc2/attachment.bin 206
ok 9  - Response without errors
[info] [<0.65.0>] 127.0.0.1 - - OPTIONS /etap-test-db 204
ok 10  - db Access-Control-Allow-Methods ok
[info] [<0.65.0>] 127.0.0.1 - - GET /etap-test-db1 200
ok 11  - db origin ok
[info] [<0.65.0>] 127.0.0.1 - - OPTIONS / 405
ok 12  - check non defined host:port in origin ok
[info] [<0.65.0>] 127.0.0.1 - - OPTIONS / 405
ok 13  - check non defined scheme in origin ok
[info] [<0.65.0>] 127.0.0.1 - - GET /etap-test-db/doc2 200
[info] [<0.65.0>] 127.0.0.1 - - GET /etap-test-db/doc2 304
ok 14  - Responded with Not Modified
[info] [<0.65.0>] 127.0.0.1 - - OPTIONS / 204
ok 15  - check host:port in origin ok
[info] [<0.65.0>] 127.0.0.1 - - OPTIONS / 204
ok 16  - check scheme in origin ok
[info] [<0.65.0>] 127.0.0.1 - - OPTIONS / 204
ok 17  - db origin ok
[info] [<0.65.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 18  - db access config case mismatch
[info] [<0.65.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 19  - db Access-Control-Allow-Credentials off
[info] [<0.65.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 20  - db Access-Control-Allow-Credentials ok
[info] [<0.65.0>] 127.0.0.1 - - OPTIONS / 204
ok 21  - test_preflight_request Access-Control-Allow-Methods ok
[info] [<0.65.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 22  - db Access-Control-Allow-Origin ok
ok 23  - db Access-Control-Expose-Headers ok
[info] [<0.65.0>] 127.0.0.1 - - OPTIONS /etap-test-db 204
ok 24  - db Access-Control-Allow-Methods ok
[info] [<0.65.0>] 127.0.0.1 - - GET /etap-test-db1 200
ok 25  - db origin ok
[info] [<0.65.0>] 127.0.0.1 - - OPTIONS / 405
ok 26  - check non defined host:port in origin ok
[info] [<0.65.0>] 127.0.0.1 - - OPTIONS / 405
ok 27  - check non defined scheme in origin ok
All 26 subtests passed

Test Summary Report
-------------------
./test/etap/231-cors.t (Wstat: 0 Tests: 27 Failed: 1)
   Failed test:  27
   Parse errors: Bad plan.  You planned 26 tests but ran 27.
Files=1, Tests=27,  2 wallclock secs ( 0.06 usr  0.02 sys +  0.74 cusr
  0.25 csys =  1.07 CPU)
Result: FAIL


$ ./test/etap/run -v ./test/etap/231-cors.t
./test/etap/231-cors.t ..
./test/etap/231-cors.t:429: Warning: variable 'Else' is unused
# Current time local 2014-04-29 13:12:27
# Using etap version "0.3.4"
1..26
Apache CouchDB 0.0.0 (LogLevel=info) is starting.
Apache CouchDB has started. Time to relax.
[info] [<0.2.0>] Apache CouchDB has started on http://127.0.0.1:40513/
[info] [<0.64.0>] 127.0.0.1 - - GET / 200
ok 1  - No CORS Headers when disabled
[info] [<0.65.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 2  - No CORS Headers when disabled
[info] [<0.66.0>] 127.0.0.1 - - GET / 200
ok 3  - Specified invalid origin, no Access
[info] [<0.67.0>] 127.0.0.1 - - OPTIONS / 405
ok 4  - invalid origin
[info] [<0.68.0>] 127.0.0.1 - - OPTIONS / 204
ok 5  - test_preflight_request Access-Control-Allow-Methods ok
[info] [<0.69.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 6  - db Access-Control-Allow-Origin ok
ok 7  - db Access-Control-Expose-Headers ok
[info] [<0.70.0>] 127.0.0.1 - - PUT /etap-test-db/doc1/attachment.txt 201
[info] [<0.71.0>] 127.0.0.1 - - GET /etap-test-db/doc1?attachments=true 200
ok 8  - Response without errors
[info] [<0.72.0>] 127.0.0.1 - - PUT /etap-test-db/doc2/attachment.bin 201
[info] [<0.73.0>] 127.0.0.1 - - GET /etap-test-db/doc2/attachment.bin 206
ok 9  - Response without errors
[info] [<0.64.0>] 127.0.0.1 - - OPTIONS /etap-test-db 204
ok 10  - db Access-Control-Allow-Methods ok
[info] [<0.64.0>] 127.0.0.1 - - GET /etap-test-db1 200
ok 11  - db origin ok
[info] [<0.64.0>] 127.0.0.1 - - OPTIONS / 405
ok 12  - check non defined host:port in origin ok
[info] [<0.64.0>] 127.0.0.1 - - OPTIONS / 405
ok 13  - check non defined scheme in origin ok
[info] [<0.64.0>] 127.0.0.1 - - GET /etap-test-db/doc2 200
[info] [<0.64.0>] 127.0.0.1 - - GET /etap-test-db/doc2 304
ok 14  - Responded with Not Modified
[info] [<0.64.0>] 127.0.0.1 - - OPTIONS / 204
ok 15  - check host:port in origin ok
[info] [<0.64.0>] 127.0.0.1 - - OPTIONS / 204
ok 16  - check scheme in origin ok
[info] [<0.64.0>] 127.0.0.1 - - OPTIONS / 204
ok 17  - db origin ok
[info] [<0.64.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 18  - db access config case mismatch
[info] [<0.64.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 19  - db Access-Control-Allow-Credentials off
[info] [<0.64.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 20  - db Access-Control-Allow-Credentials ok
[info] [<0.64.0>] 127.0.0.1 - - OPTIONS / 204
ok 21  - test_preflight_request Access-Control-Allow-Methods ok
[info] [<0.64.0>] 127.0.0.1 - - GET /etap-test-db 200
ok 22  - db Access-Control-Allow-Origin ok
ok 23  - db Access-Control-Expose-Headers ok
[info] [<0.64.0>] 127.0.0.1 - - OPTIONS /etap-test-db 204
ok 24  - db Access-Control-Allow-Methods ok
[info] [<0.64.0>] 127.0.0.1 - - GET /etap-test-db1 200
ok 25  - db origin ok
[info] [<0.64.0>] 127.0.0.1 - - OPTIONS / 405
ok 26  - check non defined host:port in origin ok
[info] [<0.64.0>] 127.0.0.1 - - OPTIONS / 405
ok
All tests successful.
Files=1, Tests=26,  2 wallclock secs ( 0.06 usr  0.01 sys +  0.76 cusr
  0.27 csys =  1.10 CPU)
Result: PASS

Looks like yet another floating issue which isn't floating for R14.

--
,,,^..^,,,

Reply via email to