On 25 Jan 2011, at 18:54, Benoit Chesneau wrote: > On Tue, Jan 25, 2011 at 6:41 PM, Filipe David Manana > <[email protected]> wrote: >> On Tue, Jan 25, 2011 at 5:23 PM, Benoit Chesneau <[email protected]> wrote: >>> >>> shouldn't MAX_RETRY be a config setting ? >>> >> >> If there are many people who wish the value for MAX_RETRIES to be >> configurable, then yes. Only left as a constant to avoid increasing >> the size of our .ini configuration. >> > There are cases where you want to reduce retries, or in the contrary > increasing them. For example when you go in offline mode or work with > moving machines (mobiles to mobiles) . So I guess yes, having it as a > setting would be useful. And 10 is a pretty high number for a default > I think.
Adding config variables for this is an easy patch. We've had plenty of variable that started out as a constant, I don't see a problem with making this one configurable. Why do you think 10 is high? What do you suggest and why? Cheers Jan --
