[ 
https://issues.apache.org/jira/browse/COUCHDB-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986061#action_12986061
 ] 

Klaus Trainer commented on COUCHDB-902:
---------------------------------------

Yeah, we should get that into trunk soon.

The only question that I still see as open is about testing. In the 
corresponding fix for 1.0.2 (see 
https://github.com/apache/couchdb/commit/8432c0e8f31a683b13419dc591edca49933d1f81),
 we have accordant futon tests in the (new) file `attachment_conflicts.js`. 
Also, there's Bob's new etap test (see 
https://github.com/bdionne/couchdb/commit/1a276a#diff-7) for couch_key_tree.

Shouldn't we include those tests in the fix?

> Attachments that have recovered from conflict do not accept attachments.
> ------------------------------------------------------------------------
>
>                 Key: COUCHDB-902
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-902
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>         Environment: trunk
>            Reporter: Paul Joseph Davis
>            Priority: Critical
>             Fix For: 1.0.2, 1.1
>
>         Attachments: 0001-Fix-COUCHDB-902.patch, 902.patch, 
> couchdb-902-test-case.py
>
>
> Apparently if a document has been in a conflict, they will reject requests to 
> add an attachment with a conflict error.
> I've tracked this down to couch_db_updater.erl line 501, but I'm not too 
> familiar with this part of the code so I figured I'd fill out a ticket in 
> case anyone else can go through this more quickly than me.
> Sure would be nice if I could attach a file when I create an issue...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to