I vote +1:

* signature & hash ok
* tag ok
* npm audit fine as Norman noted
* changes look good for patch
* tests good (as far as testing on Linux is possible)

On September 3, 2023, Norman Breau <nor...@nbsolutions.ca> wrote:
> I vote +1:
>
> - Ran NPM Audit:
>    Moderate vulnerability in semver, in a dev dependency which could 
> result in DoS.
>    I don't consider this a blocker, and can be corrected in the next 
> release.
> - Verified Tags
> - Verified Archive
>
> On 2023-09-03 8:47 a.m., Bryan Ellis wrote:
> > Please review and vote on this Cordova-iOS Release v7.0.1
> > by replying to this email (and keep discussion on the DISCUSS
> thread)
> >
> > The archive has been published to dist/dev:
> >
> > https://dist.apache.org/repos/dist/dev/cordova/ios-v7.0.1
> >
> > The package was published from its corresponding git tag:
> >
> > cordova-ios: 7.0.1 (a34bbf7887)
> >
> > Note that you can test it out via:
> >
> > cordova platform add https://github.com/apache/cordova-ios#7.0.1
> >
> > Upon a successful vote I will upload the archive to dist/, publish
> it to npm, and post the blog post.
> >
> > Voting guidelines: https://github.com/apache/cordova-
> coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > =====
> >
> > I vote +1:
> >
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * NPM Audit
> > * 1 moderate severity vulnerability detected in a dev dependency but
> is unrelated to the production release
> > * NPM Test
> > * Ran `cordova build` test
> > * Ran `cordova run` emulator test
> > * Ran `cordova plugin add` test
> >
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to