I vote +1 * signature & hash ok * no audit issues * test pass locally * tag ok * CI green * android platform builds with nightly
On May 13, 2023, Norman Breau <nor...@nbsolutions.ca> wrote: > I vote +1: > > - Verified Tags > - Verified Archive > - Ran npm test on linux > - NPM Audit returns 0 issues > > On 2023-05-13 1:06 a.m., Bryan Ellis wrote: > > Please review and vote on this cordova-lib release v12.0.0 > > by replying to this email (and keep discussion on the DISCUSS > thread) > > > > The archive has been published to dist/dev: > > > > https://dist.apache.org/repos/dist/dev/cordova/lib-12.0.0 > > > > The package was published from its corresponding git tag: > > > > cordova-lib: 12.0.0 (ac491cdc5f) > > > > Upon a successful vote I will upload the archive to dist/, publish > it to npm, and post the blog post. > > > > Voting guidelines: https://github.com/apache/cordova- > coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > ===== > > > > I vote +1: > > > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and sub- > dependencies have Apache-compatible licenses > > * Ensured the continuous build was green when repo was tagged > > * Ran `npm test` > > > > * Ran various `cordova` test w/ sample app: > > * `cordova` > > * `cordova -v` > > * `cordova create` > > * `cordova info` > > * `cordova help` > > * `cordova config ls` > > * `cordova requirements` > > * `cordova telemetry` > > * `cordova platform` > > * `cordova platform add` > > * `cordova platform rm` > > * `cordova plugin` > > * `cordova plugin add` > > * `cordova plugin rm` > > * `cordova build` > > * `cordova prepare` > > * `cordova compile` > > * `cordova run` > > * `cordova serve` > > > > * Ran `npm audit` > > > > 0 vulnerabilities > > > > Additional Notes: > > Deprecation warnings will appear during installation for two > packages. These are just warnings and do not cause any issues. In a > future release, these warnings will be resolved. > > > > npm WARN deprecated stringify-package@1.0.1: This module is not used > anymore, and has been replaced by @npmcli/package-json > > npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has > been moved to @npmcli/fs > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org
