I vote +1 * signature & hash ok * no audit issues * no licenses flagged * tests pass (Mac NodeJS 18 LTS) * license headers ok * tag ok
Thanks erisu! On April 6, 2023, Erisu <er...@apache.org> wrote: > Please review and vote on this cordova-fetch release v4.0.0 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/fetch-4.0.0 > > The package was published from its corresponding git tag: > > cordova-fetch: 4.0.0 (f1f9ff3b9d) > > Upon a successful vote I will upload the archive to dist/, publish it > to npm, and post the blog post. > > Voting guidelines: https://github.com/apache/cordova- > coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > ==== > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and sub- > dependencies have Apache-compatible licenses > * Ensured the continuous build was green when repo was tagged > * Ran `npm test` > > * Ran various `cordova` test w/ sample app: > * `cordova` > * `cordova -v` > * `cordova create` > * `cordova info` > * `cordova help` > * `cordova config ls` > * `cordova requirements` > * `cordova telemetry` > * `cordova platform` > * `cordova platform add` > * `cordova platform rm` > * `cordova plugin` > * `cordova plugin add` > * `cordova plugin rm` > * `cordova build` > * `cordova prepare` > * `cordova compile` > * `cordova run` > * `cordova serve` > > * Ran `npm audit` > > 0 vulnerabilities