I vote +1 - changes look good - archive ok - tag ok - no audit issues - tests pass locally
On January 30, 2023, Norman Breau <nor...@nbsolutions.ca> wrote: > I vote +1: > > - Ran NPM test on local linux environment. All green. > - Verified archive > - Verified tags > > On 2023-01-30 1:26 a.m., Bryan Ellis wrote: > > Please review and vote on this cordova-serve release v4.0.1 > > by replying to this email (and keep discussion on the DISCUSS > thread) > > > > The archive has been published to dist/dev: > > > > https://dist.apache.org/repos/dist/dev/cordova/serve-4.0.1 > <https://dist.apache.org/repos/dist/dev/cordova/serve-4.0.1> > > > > > > The package was published from its corresponding git tag: > > > > cordova-serve: 4.0.1 (9b24c468d3) > > > > Upon a successful vote I will upload the archive to dist/, publish > it to npm, and post the blog post. > > > > Voting guidelines: https://github.com/apache/cordova- > coho/blob/master/docs/release-voting.md > <https://github.com/apache/cordova-coho/blob/master/docs/release- > voting.md> > > > > Voting will go on for a minimum of 48 hours. > > > > === > > > > I vote +1: > > > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and sub- > dependencies have Apache-compatible licenses > > * Ensured the continuous build was green when repo was tagged > > * Ran `npm test` > > > > * Ran various `cordova` test w/ sample app: > > * `cordova serve` > > > > * Ran `npm audit` > > > > 0 vulnerabilities > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org
