I vote +1

I checked:

* signature & hash ok
* tag ok
* no audit issues
* tests pass
* changes look good https://github.com/apache/cordova-
eslint/compare/rel/4.0.0...5.0.0
* licenses & headers ok

Note: 
RAT raised a new 3rd party license warning. This release now includes
the package argparse. Which has the Python 2.0 license which should be
compatible [2]. So this is fine.

Thanks for your work!

On January 16, 2023, Erisu <er...@apache.org> wrote:
> Please review and vote on this Cordova ESLint Major Release v5.0.0
> (v2)
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> The archive has been published to dist/dev:
>
>  https://dist.apache.org/repos/dist/dev/cordova/eslint-v5.0.0
> <https://dist.apache.org/repos/dist/dev/cordova/eslint-v5.0.0>
>
>
> The package was published from its corresponding git tag:
>
>  cordova-eslint: 5.0.0 (b1b15261d4)
>
>
> Upon a successful vote I will upload the archive to dist/, publish it
> to npm, and post the blog post[?].
>
> Voting guidelines: https://github.com/apache/cordova-
> coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> ===
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * NPM Audit
> * NPM Test

Reply via email to