I vote +1 * signature & hash ok * warning appears with Cordova-Android 11 * Apps build * tag ok * no audit issues * changelog looks good
On July 12, 2022, Erisu <er...@apache.org> wrote: > Please review and vote on this cordova-plugin-splashscreen Release > v6.0.2 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/splashscreen-v6.0.2 > <https://dist.apache.org/repos/dist/dev/cordova/splashscreen-v6.0.2> > > The package was published from its corresponding git tag: > cordova-plugin-splashscreen: 6.0.2 (d2937ad489) > > Upon a successful vote I will upload the archive to dist/, publish it > to npm, and post the blog post. > > Voting guidelines: https://github.com/apache/cordova- > coho/blob/master/docs/release-voting.md > <https://github.com/apache/cordova-coho/blob/master/docs/release- > voting.md> > > Voting will go on for a minimum of 48 hours. > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and sub- > dependencies have Apache-compatible licenses > * Ensured the npm audit report was sufficient for release > * Built iOS & Android project w/ CLI > * Run iOS & Android project w/ CLI (Simulator) > > CI Results: > > The Android test failure is potentially caused by paramedic trying to > run against the Cordova-Android 11.0.0 platform which the plugin will > not be installed to. Previous runs were passing and the only > difference is that Cordova-Android 11 was not released at that time. > This is expected. > > Audit Report: > > 0 vulnerabilities found > > Additional Tests: > > I also confirmed that installing this plugin on Cordova-Android 11 > will result in the following warning: > > Plugin doesn't support this project's cordova-android version. > cordova-android: 11.0.0, failed version requirement: >=3.6.0 <11.0.0 > Skipping 'cordova-plugin-splashscreen' for android > > and it continues to install as expected with Cordova-Android 10.x