The vote has now closed. The results are: Positive Binding Votes: 3
Bryan Ellis Ken Naito Niklas Merz Negative Binding Votes: 0 Other Votes: 0 The vote has passed. > On May 27, 2022, at 18:00, Niklas Merz <niklasm...@apache.org> wrote: > > I vote +1 > > * hash ok > * signatue ok > * no audit issues > * tests green > * 100% coverage > * hash ok > > Note: I was unable to build an electron app because it was looking for a > python installation in the wrong path: Exit code: ENOENT. spawn > /usr/bin/python ENOENT. This might be a setup problem on my M1 Mac. > > On May 27, 2022, Ken Naito <kna...@apache.org> wrote: >> +1 >> >> I did: >> * coho verify-archive OK >> * coho verify-tags OK >> * The last commit b1b7a6ad910e9dae0dae23d44b7cf195615be947 is green >> >> Thanks! >> >> >> >> >> On 2022/05/25 17:31, Bryan Ellis wrote: >>> Please review and vote on this Electron Release v3.1.0 >>> by replying to this email (and keep discussion on the DISCUSS >> thread) >>> >>> The archive has been published to dist/dev: >>> https://dist.apache.org/repos/dist/dev/cordova/electron-v3.1.0 >>> >>> >>> The package was published from its corresponding git tag: >>> cordova-electron: 3.1.0 (b1b7a6ad91) >>> >>> >>> Note that you can test it out via: >>> cordova platform add https://github.com/apache/cordova- >> electron#3.1.0 >>> >>> >>> Upon a successful vote I will upload the archive to dist/, publish >> it to npm, and post the blog post. >>> >>> Voting guidelines: https://github.com/apache/cordova- >> coho/blob/master/docs/release-voting.md >>> >>> Voting will go on for a minimum of 48 hours. >>> >>> ————— >>> >>> I vote +1: >>> >>> * Ran `coho audit-license-headers` over the relevant repos >>> * Ran `coho check-license` to ensure all dependencies and sub- >> dependencies have Apache-compatible licenses >>> * Ensured the `npm audit` report was sufficient for release >>> * Ensured continuous build was green when repo was tagged >>> * Ran `npm test` >>> * Ran following `cordova` test in sample project: >>> * `cordova platform add cordova-electron-3.1.0.tgz` >>> * `cordova plugin add` >>> * `cordova build electron` >>> * `cordova run electron --nobuild` >>> >>> Note: >>> Using thee latest macOS will result in build failures due to missing >> python path. Fix will be in next major release. >>> The fix was not possible for this minor release as it requires a >> major bump of the electron-builder dependency and the increase of node >> engine requirement of >=14.14. >>> There is an unsupported workaround solution in the fix PR: >> https://github.com/apache/cordova-electron/pull/227 >>> >> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> For additional commands, e-mail: dev-h...@cordova.apache.org >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org
