I vote +1 Changes look good.
Op vr 13 aug. 2021 08:53 schreef Niklas Merz <niklasm...@apache.org>: > I vote +1 (binding). > > I checked: > > - Hash & Signature > - Tag Hash > - Tests pass locally > - License exists > - License headers > > On August 13, 2021, Benjamin Tietze <btie...@telepups.de> wrote: > > I vote +1 (non-binding) > > > > I checked the following: > > - Licence > > - Change log > > - Quick test with our app > > - Release Hash > > > > > > Am Fr., 13. Aug. 2021 um 07:06 Uhr schrieb Bryan Ellis > > <er...@apache.org>: > > > > > Please review and vote on this Cordova-Android Release v10.1.0 > > > by replying to this email (and keep discussion on the DISCUSS > > thread) > > > > > > The archive has been published to dist/dev: > > > https://dist.apache.org/repos/dist/dev/cordova/android-v10.1.0 > > > > > > The package was published from its corresponding git tag: > > > cordova-android: 10.1.0 (c3fd6bca4a) > > > > > > Note that you can test it out via: > > > > > > cordova platform add https://github.com/apache/cordova- > > android#10.1.0 > > > > > > Upon a successful vote I will upload the archive to dist/, publish > > it to > > > npm, and post the blog post. > > > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release- > > voting.md > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > === > > > > > > I vote +1: > > > > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and > > subdependencies > > > have Apache-compatible licenses > > > * Ensured continuous build was green when repo was tagged > > > * NPM Audit (See Below) > > > * NPM Test (Executed Individual Steps in Order) > > > * npm run lint > > > * npm run unit-test > > > * npm run e2e-tests > > > * npm run java-unit-tests > > > * Ran `cordova build` test > > > * Ran `cordova run` emulator test > > > * Ran `cordova plugin add` test > > > > > > > > > ==NPM Audit Report== > > > > > > One moderate severity vulnerability was detected. It is from a > > > sub-dependencies of cordova-common. Rebuilding the package-lock.json > > for > > > this package does not resolve it. The "cordova-common" package will > > require > > > a new release in the future. This detection should not block this > > > cordova-android release vote. > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > >
