I vote +1 Changes look good. I am unable to do any further testing right now.
Kind regards Pieter Op za 17 jul. 2021 10:42 schreef Niklas Merz <m...@hey.com.invalid>: > I vote +1 > > I did: > > * checked signature > * checked hash > * checked license > * checked git tag > * tests pass locally > * ci green > * no lint issues > * short test with new and existing app > > On July 17, 2021, Erisu <er...@apache.org> wrote: > > Please review and vote on this Android Release v10.0.0 > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/android-v10.0.0/ > > > > The package was published from its corresponding git tag: > > cordova-android: 10.0.0 (7572fc4912) > > > > Note that you can test it out via: > > > > cordova platform add https://github.com/apache/cordova-android#10.0.0 > > > > Upon a successful vote I will upload the archive to dist/, publish it > > to npm, and post the blog post. > > > > Voting guidelines: https://github.com/apache/cordova- > > coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Ensured continuous build was green when repo was tagged > > * NPM Audit > > * NPM Test (Executed Individual Steps in Order) > > * npm run lint > > * npm run unit-test > > * npm run e2e-tests > > * npm run java-unit-tests > > * Ran `cordova build` test > > * Ran `cordova run` emulator test > > * Ran `cordova plugin add` test > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org >
