I vote +1 * checked hash and signature * no audit issues * checked version numbers * verified tag
On June 29, 2021, Norman Breau <nor...@nbsolutions.ca> wrote: > I vote +1: > > * Ran verify-archive > * Ran verify-tags > * Checked Travis CI for mentioned failure -- Appears to be > failing when testing against iOS, despite this plugin having an > iOS > implementation. > Agreed that this is not a blocker for this release, which is to > finalize the deprecation of this plugin. > > On 2021-06-28 4:51 p.m., pieter van poyer wrote: > > Please review and vote on the release of this plugins release by > > replying to this email (and keep discussion on the DISCUSS thread) > > > > The plugins have been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin- > whitelist20210626/ > > > > The packages were published from their corresponding git tags: > > cordova-plugin-whitelist: 1.3.5 (2e5db06c9a) > > > > Upon a successful vote I will upload the archives to dist/, upload > > them to npm, and post the corresponding blog post. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/release- > voting.md > > How to vote on a plugins release at > > https://github.com/apache/cordova-coho/blob/master/docs/plugins- > release-process.md#voting > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Ensured continuous build was green when repos were tagged - some > > MacOS CI builds are failing for a long time, no reason to delay the > > reason.* Checked npm audit & npm outdated -> there are no npm > > dependencies in the package.json > > > > Release notes: https://github.com/apache/cordova-plugin- > whitelist/blob/1.3.x/RELEASENOTES.md#135-jun-26-2021 > > Announcement Blog Post PR: https://github.com/apache/cordova- > docs/pull/1180 > > > > Kind regards > > Pieter > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org
