+1 * Confirmed verification of the archive signature & hashes * Verified the sha hash of the release tag * Confirmed re-created archive matches submitted release candidate * Verified NPM Audit * Confirmed existance of LICENSE & NOTICE file * Verified plugin add * Verified build of Android & iOS w/ plugin * Verified run of Android & iOS w/ plugin * Confirmed basic IAB usage `cordova.InAppBrowser.open` w/ Android & iOS
> On Nov 18, 2020, at 6:36, Norman Breau <nor...@nbsolutions.ca> wrote: > > I vote +1: > > * Audit licenses > * Ran check-license > * Verified tags > * Verified archive > > On Nov 17 2020, at 2:31 pm, Niklas Merz <niklasm...@apache.org> wrote: >> Please review and vote on the release of this plugins release >> by replying to this email (and keep discussion on the DISCUSS thread) >> >> The plugins have been published to dist/dev: >> https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-inappbrowser-4.1.0/ >> >> The packages were published from their corresponding git tags: >> cordova-plugin-inappbrowser: 4.1.0 (e0216b0d03) >> >> Upon a successful vote I will upload the archives to dist/, upload them >> to npm, and post the corresponding blog post together with the other >> plugins. >> >> Voting guidelines: >> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md >> How to vote on a plugins release at >> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting >> >> Voting will go on for a minimum of 48 hours. >> I vote +1: >> * Checked audit issues >> * Checked license headers >> * Checked licenses with coho check-license -r . >> * Did some basic tests with an app >> >> NOTE: The CI is failing right now for all plugins. >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
