I vote +1: - ✅ coho verify-archive cordova-common-4.0.2.tgz - CI is green - changes make sense - LICENSE and NOTICE file are present - ✅ npm cit locally
On Wed, Jul 1, 2020 at 4:51 PM Niklas Merz <niklasm...@apache.org> wrote: > I vote +1 > > * verified hash > * verified signature > * npm install and no audit issues > * checked license headers > * checked existence of license > * checked tag with coho > * CI green > * tests pass locally > * changes make sense for patch > > July 1, 2020 4:31 PM, "Bryan Ellis" <er...@apache.org> wrote: > > > Please review and vote on this Cordova Common v4.0.2 Release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/common-v4.0.2 > > > > The package was published from its corresponding git tag: > > cordova-common: 4.0.2 (f2c2a8d326) > > > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog > > post. > > > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho "audit-license-headers" over the relevant repos > > * Ran coho "check-license" to ensure all dependencies and > subdependencies have Apache-compatible > > licenses > > * Ensured the continuous build was green when repo was tagged > > * Ensured the "npm audit" had 0 vulnerabilities at time of release vote > creation > > * Ensure the "npm tests" were passing locally and on CI services > > * Ran build test > > * Run simulator test > > * Tested with two plugins that contains a "config-file" element > targeting "*-Info.plist" > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
