The vote has now closed. The results are: Positive Binding Votes: 4
* Bryan Ellis * Niklas Merz * Chris Brody * Norman Breau Negative Binding Votes: 0 The vote has passed. Thanks everyone! > On Jun 25, 2020, at 6:16, Norman Breau <nor...@normanbreau.com> wrote: > > +1 > > * Tests passed locally > * Tested in some of my production apps > * npm audit found 0 vulnerabilities > * Tags were verified > * Archived was verified > > On 2020-06-24 3:40 p.m., Chris Brody wrote: >> +1, with some comments: >> >> Tag for 9.0.0 looks consistent between git and the coho output. >> >> I tested adding cordova version 9.0.0 from GitHub into >> cordova-sqlite-storage test app. >> >> A major customer has been using recent cordova-android version from GitHub, >> as needed to get the response cutoff bugfix that I had raised in PR #987, >> and it has remained stable under some heavy data load. >> >> I tried to use cordova-mobile-spec but was held up by a git error: >> https://github.com/apache/cordova-mobile-spec/issues/207 >> >> Some commits for the 9.0.0 major release are in a separate 9.0.x branch. As >> I had said before, I think it would be much better if all commits for a >> major release would be in master to keep a more linear and cohesive history >> in git. This was already tracked here: >> https://github.com/apache/cordova-coho/issues/227 >> >> I hope we can find a way to improve this in the near future. Maybe we >> should just add some documentation for now and revisit the tooling in the >> future. >> >> >> On Wed, Jun 24, 2020 at 6:27 AM Niklas Merz <niklasm...@apache.org> wrote: >> >>> I vote +1 >>> >>> I did: >>> * checked hash >>> * checked signature >>> * verified tag >>> * npm audit green >>> * checked license headers >>> * checked license >>> * tests pass locally >>> * CI for tag green >>> * new test app runs with platform >>> >>> June 24, 2020 5:43 AM, "Bryan Ellis" <er...@apache.org> wrote: >>> >>>> Please review and vote on this Cordova-Android Release v9.0.0 >>>> by replying to this email (and keep discussion on the DISCUSS thread) >>>> >>>> The archive has been published to dist/dev: >>>> https://dist.apache.org/repos/dist/dev/cordova/android-v9.0.0 >>>> >>>> The package was published from its corresponding git tag: >>>> cordova-android: 9.0.0 (cdcb4ddcd9) >>>> >>>> Note that you can test it out via: >>>> >>>> cordova platform add https://github.com/apache/cordova-android#9.0.0 >>>> >>>> Upon a successful vote I will upload the archive to dist/, publish it to >>> npm, and post the blog >>>> post. >>>> >>>> Voting guidelines: >>> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md >>>> Voting will go on for a minimum of 48 hours. >>>> >>>> I vote +1: >>>> * Ran coho audit-license-headers over the relevant repos >>>> * Ran coho check-license to ensure all dependencies and subdependencies >>> have Apache-compatible >>>> licenses >>>> * Ensured the continuous build was green when repo was tagged >>>> * Ensured the npm audit had 0 vulnerabilities at time of release vote >>> creation >>>> * Ensure the npm tests were passing locally and on CI services >>>> * Ran build test with CLI & bin >>>> * Run simulator test with CLI & bin >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>>> For additional commands, e-mail: dev-h...@cordova.apache.org >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> For additional commands, e-mail: dev-h...@cordova.apache.org >>> >>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
