I just looked at that PR now that someone provided be with good reproduction steps. It looks good to me. I would like to see at least one other person review before I merge, preferably by Thursday. Otherwise I'd vote to continue on with a release, and then create a patch sometime later.

On 2020-06-12 3:58 p.m., Chris Brody wrote:
My one objection is what looks like lack of handling of external
contributions, in particular this one:
https://github.com/apache/cordova-android/pull/971


On Thu, Jun 11, 2020 at 10:42 PM Bryan Ellis <er...@apache.org> wrote:

I am looking at restarting this thread.

Let’s get this release going by Friday of next week. (June 19th)

If there are any remaining tasks, let’s try and complete and merge them
before Friday of next week. If they can't be completed, then those tasks
should be postponed for a later release.

If no one has any remaining tasks, we can prepare the release earlier of
next week instead.

Please reply as soon as possible and try not to delay until the last
minute.



On Sat, Apr 18, 2020 at 11:32 PM Norman Breau <nor...@normanbreau.com>
wrote:

I just realized that the latest android gradle plugin is at version
3.6.0, currently our master is using 3.5.3. When it comes to this
plugin, 3.x version changes are considered major updates with potential
breaking changes.


So I wonder if we should get that bumped up to the latest version? This
could future-proof ourselves should any feature actually depend on
3.6.0+. If we don't do this, then we would have to wait for another
major release.

On 2020-04-18 2:56 a.m., Bryan Ellis wrote:
Does anyone have any reason to delay a cordova-android major release
(9.0.0)?
Any additional outstanding changes to land?

If not, I will start the release process in the next couple of days.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to