+1 * Confirmed signature & hash with `coho verify-archive` * Verified that SHA matches tags with `coho verify-tags` * Tested `plugin add` * Tested `build` with plugin added * Verified that the CI is green for tag and branch
On Tue, Jan 7, 2020 at 1:46 AM Chris Brody <chris.br...@gmail.com> wrote: > +1 > > Tested from master branch on GitHub using > https://github.com/dpa99c/cordova-plugin-inappbrowser-test > > on iOS for 3.2.0 RC2 (no changes to Android since first 3.2.0 minor release > candidate) > > checked that the git tag is consistent > > On Mon, Jan 6, 2020 at 1:39 AM Niklas Merz <niklasm...@apache.org> wrote: > > > Please review and vote on the release of this plugins release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > The plugins have been published to dist/dev: > > > > > https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-inappbrowser-3.2.0-RC2/ > > > > The packages were published from their corresponding git tags: > > cordova-plugin-inappbrowser: 3.2.0 (81aa8ba5a9) > > > > Upon a successful vote I will upload the archives to dist/, upload them > > to npm, and post the corresponding blog post. > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > How to vote on a plugins release at > > > > > https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md#voting > > > > Voting will go on for a minimum of 48 hours. > > I vote +1: > > * No NPM audit warnings > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and subdependencies > > have Apache-compatible licenses > > * Checked continuous build > > * Did tests with an app that uses InAppBrowser and WKWebViewOnly > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >