+1 - coho verify-archive + verify-tags - ci green - reviewed commits
On Wed, Jan 1, 2020 at 11:48 AM Niklas Merz <niklasm...@apache.org> wrote: > (sending again because of formatting issues, Thunderbird can be hard to > use) > > +1 > > * Confirmed sigs & hashes with `coho verify-archive` > * Verified sha1s match tags with `coho verify-tags` > * Did a quick review of the commits of the diff for this tag > https://github.com/apache/cordova-windows/compare/7.0.0...7.0.1 > * CI is green for 3ba08bd80a > > > Am 01.01.20 um 20:42 schrieb Niklas Merz: > > +1 > > > > |* Confirmed sigs & hashes with `coho verify-archive` |||* Verified > sha1s match tags with `coho verify-tags` * Did a quick > > review of the commits of the diff for this tag > > https://github.com/apache/cordova-windows/compare/7.0.0...7.0.1 * CI is > > green for ||||3ba08bd80a|| > > > > Am 31.12.19 um 19:14 schrieb Chris Brody: > >> Happy New Year! Please review and vote on this cordova-windows@7.0.1 > patch > >> release by replying to this email (and keep discussion in the DISCUSS > >> thread). > >> > >> A quick review of the release notes would be much appreciated as well: > >> https://github.com/apache/cordova-docs/pull/1048 > >> > >> Please note the following: > >> * I have *manually* updated the version in all of the required places, > >> including cordova.js > >> * there have been no updates to cordova-js-src between 7.0.0 and > proposed > >> 7.0.1 patch release on GitHub > >> * cordova.js is not updated from cordova-js or internal cordova-js-src > >> files (should be OK since no updates from cordova-js-src need to be > applied > >> in this patch release) > >> > >> The archive has been published to dist/dev: > >> https://dist.apache.org/repos/dist/dev/cordova/cordova-windows-7.0.1/ > >> > >> The package was published from its corresponding git tag: > >> cordova-windows: 7.0.1 (3ba08bd80a) > >> > >> Note that you can test it out via: > >> > >> cordova platform add > https://github.com/apache/cordova-windows#7.0.1 > >> > >> Upon a successful vote I will upload the archive to dist/, publish it to > >> npm, and post the blog post. (As I said above, review of the proposed > blog > >> post is needed as well.) > >> > >> Voting guidelines: > >> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > >> > >> Voting will go on for a minimum of 48 hours. > >> > >> I vote +1: > >> * no npm audit warnings > >> * Ran coho audit-license-headers over the relevant repos > >> * Ran coho check-license to ensure all dependencies and subdependencies > >> have Apache-compatible licenses > >> * Ensured continuous build was green when repo was tagged > >> * cordova-sqlite-storage test project with the proposed patch update of > >> cordova-windows passes its tests on multiple target CPU types > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
