+1 - CI is green for the tag - coho verify-archive - checked out tagged commit and ran tests - created a new project and added the platform without issue
On Sun, Nov 24, 2019 at 9:03 AM Tim Brust <timbrust3...@gmail.com> wrote: > I vote +1: > > ✅ CI is green for the tag > ✅ coho verify-archive > ✅ changes make sense > ✅ npm audit > > > > On 23. Nov 2019, at 14:06, Bryan Ellis <er...@apache.org> wrote: > > > > Please review and vote on this iOS Release v5.1.0 > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/ios-v5.1.0 > > > > The package was published from its corresponding git tag: > > cordova-ios: 5.1.0 (dc327c1df4) > > > > Note that you can test it out via: > > > > cordova platform add https://github.com/apache/cordova-ios#5.1.0 > > > > Upon a successful vote I will upload the archive to dist/, publish it to > > npm, and post the blog post. > > > > Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and subdependencies > > have Apache-compatible licenses > > * Ensured continuous build was green when repo was tagged > > * NPM Audit > > * NPM Tests > >
