I vote +1: * `npm test` passes (Lints itself) * I manually tested it on cordova-create
Am Do., 7. Nov. 2019 um 12:07 Uhr schrieb Bryan Ellis <er...@apache.org>: > Please review and vote on this Cordova ESLint Major Release v1.0.0 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/eslint-v1.0.0 > > The package was published from its corresponding git tag: > cordova-eslint: 1.0.0 (918d6a9c90) > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ensured continuous build was green when repo was tagged > * NPM Audit > * NPM Test (Lint itself) >
