raphinesse commented on a change in pull request #1: chore: added missing 
package repo & bug field
URL: https://github.com/apache/cordova-eslint/pull/1#discussion_r342642901
 
 

 ##########
 File path: package.json
 ##########
 @@ -6,6 +6,13 @@
   "scripts": {
     "test": "eslint ."
   },
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/apache/cordova-eslint";
+  },
 
 Review comment:
   I would prefer we do that to keep our `package.json` files as concise as 
possible, i. e.:
   ```json
   "repository": "github:apache/cordova-eslint",
   ```
   or even 
   ```json
   "repository": "apache/cordova-eslint",
   ```
   Also see the [`package.json` 
docs](https://docs.npmjs.com/files/package.json#repository)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to