+1 - CI is green - changes make sense
Am Di., 5. März 2019 um 10:33 Uhr schrieb Jesse <purplecabb...@gmail.com>: > > +1 > > - Ran coho verify-archive > - CI was green > > > @purplecabbage > risingj.com > > > On Mon, Mar 4, 2019 at 11:54 PM Bryan Ellis <er...@apache.org> wrote: > > > Please review and vote on this Windows Release v7.0.0 > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: https://github.com/apache/cordova/issues/10 > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/GH-10 > > > > The package was published from its corresponding git tag: > > cordova-windows: 7.0.0 (0e7587ad29) > > > > Note that you can test it out via: > > > > cordova platform add https://github.com/apache/cordova-windows#7.0.0 > > > > Upon a successful vote I will upload the archive to dist/, publish it to > > npm, and post the blog post. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and subdependencies > > have Apache-compatible licenses > > * Ensured continuous build was green when repo was tagged > > * NPM Audit > > * NPM Tests --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
