+1

On Thu, Feb 7, 2019 at 2:15 PM Jesse <purplecabb...@gmail.com> wrote:
>
> +1
>
> - CI green
> - verified Erisu's signature via `cohoo verify-archive`
> - npm audit on commit 7c1c99713f
> - npm test on commit 7c1c99713f
>
> @purplecabbage
> risingj.com
>
>
> On Wed, Feb 6, 2019 at 8:53 PM Bryan Ellis <er...@apache.org> wrote:
>
> > Please review and vote on this iOS Release v5.0.0
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://github.com/apache/cordova/issues/10
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/GH-10
> >
> > The package was published from its corresponding git tag:
> >     cordova-ios: 5.0.0 (7c1c99713f)
> >
> > Note that you can test it out via:
> >
> >     cordova platform add https://github.com/apache/cordova-ios#5.0.0
> >
> > Upon a successful vote I will upload the archive to dist/, publish it to
> > npm, and post the blog post.
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * NPM Audit
> > * NPM Tests
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to