The vote has now closed. The results are: Positive Binding Votes: 4 * Jesse MacFadyen * Darryl Pogue * Gandhi Rajan * Chris Brody
Negative Binding Votes: 0 The vote has passed. Thanks for the quick review. On Wed, Nov 21, 2018 at 8:12 AM gandhi rajan <gandhiraja...@gmail.com> wrote: > +1 > > npm audit successful > License check successful > Was able to create new project and add & build Android platform with out > any error. > > On Tuesday, November 20, 2018, Darryl Pogue <dar...@dpogue.ca> wrote: > > > +1 > > > > - npm audit all good > > - ran coho verify-archive over release artifacts > > > > On Mon, Nov 19, 2018 at 3:43 PM Jesse <purplecabb...@gmail.com> wrote: > > > > > > +1 > > > > > > - npm audit all good > > > - ran coho verify-archive over release artifacts > > > - created a new cordova project, and added cordova-android platform ( > > from > > > filesystem ) and build+ran on emulator > > > > > > > > > @purplecabbage > > > risingj.com > > > > > > > > > On Mon, Nov 19, 2018 at 2:17 PM Chris Brody <chris.br...@gmail.com> > > wrote: > > > > > > > Please review and vote on this cordova-android 7.1.3 patch release, > by > > > > replying to this email (and keep discussion on the DISCUSS thread) > > > > > > > > Release changes as proposed in: > > > > https://github.com/apache/cordova-android/pull/555 > > > > > > > > The archive has been published to dist/dev: > > > > https://dist.apache.org/repos/dist/dev/cordova/GH-555/ > > > > > > > > The package was published from its corresponding git tag: > > > > cordova-android: 7.1.3 (e1befaca5a) > > > > > > > > Note that you can test it out via: > > > > > > > > cordova platform add https://github.com/apache/ > > cordova-android#7.1.3 > > > > > > > > Upon a successful vote I will upload the archive to dist/, publish it > > > > to npm, and post the blog post. > > > > > > > > Voting guidelines: > > > > https://github.com/apache/cordova-coho/blob/master/docs/ > > release-voting.md > > > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > > > I vote +1: > > > > * npm audit shows 0 vulnerabilities > > > > * Ran coho audit-license-headers over the relevant repos > > > > * Ran coho check-license to ensure all dependencies and > > > > subdependencies have Apache-compatible licenses > > > > * Ensured continuous build was green when repo was tagged > > > > * Able to run self test on: > > > > https://github.com/brodybits/cordova-sqlite-test-app > > > > with cordova-android version e1befac (7.1.3) from local file > system, > > > > along with cordova-sqlite-storage@2.1.5 (with old plugin JAR & .so > > > > directory mapping) > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > -- > Regards, > Gandhi > > "The best way to find urself is to lose urself in the service of others > !!!" >
