+1 - created new project from Github tag, ran as expected - tests passing on 7.1.2 branch on Travis CI
On Tue, 6 Nov 2018, at 06:43, Jesse wrote: > +1 > > - coho verify-archive > - CI green > - created a project, added cordova-android@7.1.2 ( via tagged repo ), ran > without issue > > > > > On Mon, Nov 5, 2018 at 1:18 PM Chris Brody <chris.br...@gmail.com> wrote: > > > +1 > > > > - > > > > https://github.com/apache/cordova-android/commit/725e75fa0dc35a1b9bbc56c8621121e6dbc4fbdf > > (cordova-android@7.1.2 > > <https://github.com/apache/cordova-android/commit/725e75fa0dc35a1b9bbc56c8621121e6dbc4fbdf(cordova-android@7.1.2>) > > is green, passes its own tests OK ✓ > > > > On Mon, Nov 5, 2018 at 3:41 PM Darryl Pogue <dar...@dpogue.ca> wrote: > > > > > Please review and vote on this 7.1.2 Android Release by replying to > > > this email (and keep discussion on the DISCUSS thread). > > > > > > The archive has been published to dist/dev: > > > https://dist.apache.org/repos/dist/dev/cordova/android-712 > > > > > > Blog post for review: > > > https://github.com/apache/cordova-docs/pull/901 > > > > > > The package was published from its corresponding git tag: > > > - cordova-android: 7.1.2 (725e75fa0d) > > > > > > Note that you can test it out via: > > > > > > cordova platform add https://github.com/apache/cordova-android#7.1.2 > > > > > > Upon a successful vote I will upload the archive to dist/, publish it > > > to npm, and post the blog post. > > > > > > Voting guidelines: > > > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1: > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and > > > subdependencies have Apache-compatible licenses > > > * Ensured continuous build was green when repo was tagged > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org