It bumps gradle and gradle plugin versions, which might break old things

2018-08-02 16:28 GMT+02:00 Jan Piotrowski <piotrow...@gmail.com>:

> > Also considered adding this one about Android Studio compatibility, but
> was
> > not sure if the change might be considered breaking or at least minor, so
> > didn't do it.
>
> What would be an argument for this to be considered breaking?
>
> 2018-08-02 13:26 GMT+02:00 julio cesar sanchez <jcesarmob...@gmail.com>:
> > I've sent the PR with the cherry pick
> >
> > https://github.com/apache/cordova-android/pull/469
> >
> > It include 4 commits, 3 related to the plugins and another one about
> > simulator failing to launch.
> >
> > Also considered adding this one about Android Studio compatibility, but
> was
> > not sure if the change might be considered breaking or at least minor, so
> > didn't do it.
> >
> > https://github.com/apache/cordova-android/commit/
> > 5c4f8ca24629486847d3222263921d1aaa0a69f5
> >
> >
> >
> > 2018-07-31 0:47 GMT+02:00 Chris Brody <chris.br...@gmail.com>:
> >
> >> I would favor raising a JIRA issue to port those changes and port by
> >> cherry-pick. I would also favor not including any non-essential
> >> changes in such a patch release.
> >> On Mon, Jul 30, 2018 at 6:39 PM julio cesar sanchez
> >> <jcesarmob...@gmail.com> wrote:
> >> >
> >> > So starting in August, using at least SDK 26 as target will be
> mandatory
> >> > for submitting to google play.
> >> > The first cordova-android that targeted SDK 26 was 7.0.0, but a lot of
> >> > people is not updating because of breaking changes and plugins
> failing to
> >> > install because of them.
> >> > We have fixed the plugin compatibility in master, so I think it would
> be
> >> > good to do a new patch release with those fixes included.
> >> >
> >> > So, what should we do to add those fixes to a new release? just
> >> cherry-pick
> >> > the commits to the 7.1.x branch? With a PR or we have to use some tool
> >> > (like coho)?
> >> >
> >> > Those are the two PRs I'm talking about
> >> >
> >> > https://github.com/apache/cordova-android/pull/449
> >> > https://github.com/apache/cordova-android/pull/437
> >> >
> >> > Any other PR/commit that could be included if it's not breaking?
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Reply via email to