> > On Mon, Apr 30, 2018 at 12:37 PM Wojciech Trocki <wtro...@gmail.com> > wrote: > > Maybe I'm not understanding the goal here and it would be clearer with an > example, but it looks like this would split each action out into its own > class? I'm not sure what advantage there is to that, since you'd lose > access to all the CordovaPlugin members like the webview and > CordovaInterface. >
I agree with Darryl here, I'm not sure what that PR actually makes better? It seems to make the problem worse. > From a plugin author standpoint, a @CordovaMethod annotation to expose > specific plugin methods to JS would be ideal, but it's not such a > convenience that it's worth any performance hit. The string-based execute > is clunky, but not all that much of a problem if you just use it to > dispatch to other methods. > If annotations are 5-6 times slower than normal method calls I think this was a good idea that the OS can't handle. We are dealing with devices where 100ms makes the difference between a "smoothly performing" app and a "janky" app. Simon
