Also, I've updated cordova-plugin-device-motion and cordova-plugin-device-orientation because of the same problem. Those are deprecated plugins, but we broke them on the version that deprecated them, so I think we should release a fixed version.
2018-04-13 9:21 GMT+02:00 julio cesar sanchez <jcesarmob...@gmail.com>: > InAppBrowser had a major bump version but the cordovaDependencies have not > been updated and it will make impossible to install it from npm once it’s > published. > > > Should I -1 or you would remove it from the release process? > > > El viernes, 13 de abril de 2018, Steven Gill <stevengil...@gmail.com> > escribió: > >> Blog post for review: https://github.com/apache/cordova-docs/pull/812 >> >> On Thu, Apr 12, 2018 at 1:34 PM, Steven Gill <stevengil...@gmail.com> >> wrote: >> >> > I've reviewed the PRs. >> > >> > Julio, for vibration plugin, I'm thinking it gets documented as a quirk. >> > I'll do that and start the release now. >> > >> > >> > On Tue, Apr 10, 2018 at 12:42 AM, Niklas Merz <niklas.m...@rhoen.de> >> > wrote: >> > >> >> Not a really an important one, but I would like to see my first PR to >> >> InAppBrowser merged, so I can switch the plugin in our project back to >> >> a released version. >> >> >> >> I added an option to the InAppBrowser >> >> https://github.com/apache/cordova-plugin-inappbrowser/pull/254. >> >> >> >> Thanks >> >> >> >> Quoting julio cesar sanchez <jcesarmob...@gmail.com>: >> >> >> >> > I have this one removing navigator.notification from vibration plugin >> >> as it >> >> > has been deprecated for a long time and even removed from the docs >> >> > https://github.com/apache/cordova-plugin-vibration/pull/67. >> >> > So it might require minor or major version bump? >> >> > >> >> > Also, related issue, on Android, vibration plugin uses the browser >> >> > implementation, but looks like Google doesn't allow to vibrate >> without >> >> user >> >> > interaction first, so we should document it or go back to the native >> >> > implementation. https://issues.apache.org/jira/browse/CB-14022. >> >> > If going back to the native implementation, then we should do it for >> >> this >> >> > release, if just documenting, probably can wait. >> >> > >> >> > And I have this one for InAppBrowser plugin, was going to merge it >> but >> >> > travis is failing on one of the Android tests >> >> > https://github.com/apache/cordova-plugin-inappbrowser/pull/264 >> >> > >> >> > >> >> > 2018-04-09 19:52 GMT+02:00 Steven Gill <stevengil...@gmail.com>: >> >> > >> >> >> Going to aim to do a plugins release this Wed, April 11th. Let me >> know >> >> if >> >> >> there are any important PRs I should look at before than. >> >> >> >> >> >> >> >> >> >> > >> >
