We should be moving forward with uap only I think. Not even sure the store will accept an 8.1 app any more. We should update the tests to match. imho
> On Jan 22, 2018, at 8:08 AM, Jan Piotrowski <piotrow...@gmail.com> wrote: > > Ok, found the culprit: > > The default target version was changed from 8.1 to UAP/UWP, as VS-2017 > doesn't include the tooling for the older ones any more. > This changes what files are created of course - but the tests are > checking for specific files right now. > What should we do about those tests? > > Right now it is checking for a `.appxbundle` getting created, which is > not the case with UAP. > For UAP we also only get one app, not one build for Windows and one for Phone. > > Is this ok in practical usage of cordova-windows? > Any feedback? > > Current idea is to duplicate these tests and add a param to force 8.1 > on one set of them, and modify the other set to look for the correct > files that _are_ there. > > Best, > Jan > > > 2018-01-22 11:33 GMT+01:00 Jan Piotrowski <piotrow...@gmail.com>: >> Awesome. >> >> I am working on it in #testing in Slack. >> >> -J >> >> 2018-01-22 3:03 GMT+01:00 Jesse <purplecabb...@gmail.com>: >>> I can help you thru this in a bit, give me a couple hours and I’ll jump in >>> there. >>> >>>> On Jan 21, 2018, at 11:00 AM, Jan Piotrowski <piotrow...@gmail.com> wrote: >>>> >>>> Ok, so release is "in progress", meaning I fought/am fighting my way >>>> through >>>> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md >>>> >>>> Now I encountered failing tests and the fact that CI was broken the >>>> last few commits (tests were not run on AppVeyor). @alsorokin is >>>> helping me dig through this, but it will probably take some time until >>>> we are sure that we fixed everything and it is in a good state. >>>> >>>> (Another thing that popped up is that CI didn't run the tests with >>>> Visual Studio 2017, only 2015, but I committed a fix for that already) >>>> >>>> Will update you when there is major progress. >>>> >>>> Best, >>>> Jan >>>> >>>> >>>> >>>> 2018-01-19 12:00 GMT+01:00 Jan Piotrowski <piotrow...@gmail.com>: >>>>> Does anyone have any reason to delay a cordova-windows platform release? >>>>> Any outstanding patches to land? >>>>> >>>>> If not, I will start the release soon. >>>>> >>>>> J >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>>> For additional commands, e-mail: dev-h...@cordova.apache.org >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> For additional commands, e-mail: dev-h...@cordova.apache.org >>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
