Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/321#discussion_r123073237
  
    --- Diff: CordovaLib/Classes/Public/CDVAppDelegate.m ---
    @@ -78,9 +78,23 @@ - (BOOL)application:(UIApplication*)application 
openURL:(NSURL*)url sourceApplic
         if (!url) {
             return NO;
         }
    +    
    +    NSMutableDictionary * openURLData = [[NSMutableDictionary alloc] init];
    +    
    +    [openURLData setValue:url forKey:@"url"];
    +    
    +    if (sourceApplication) {
    +        [openURLData setValue:sourceApplication 
forKey:@"sourceApplication"];
    +    }
    +    
    +    if (annotation) {
    +        [openURLData setValue:annotation forKey:@"annotation"];
    +    }
     
    --- End diff --
    
    Personally I would have used the dictionary literals here to be more clear:
    ```
    NSMutableDictionary* openURLData = @{
         @"url" : url,
         @"sourceApplication": sourceApplication,
         @"annotation": annotation
    };
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to