Github user macdonst commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/30#discussion_r118943490
--- Diff: bin/template/cordova/Api.js ---
@@ -96,6 +96,40 @@ Api.createPlatform = function (dest, config, options,
events) {
events.emit('error','createPlatform is not callable from the
browser project API.');
throw(e);
}
+
+ // Create manifest.json
+ var manifestJson;
+ var manifestJsonPath = path.join(dest,'manifest.json');
+
+ // Check if path exists and require manifestJsonPath.
+ if(fs.existsSync(manifestJsonPath)) {
+ try {
+ manifestJson = require(manifestJsonPath);
+ }
+ catch (e) {
+ console.log("error : " + e);
+ events.emit('error', 'unable to require manifest.json path.');
+ }
+ } else if (manifestJson === undefined) {
+ manifestJson = {};
+ if(config){
+ if(config.name()) {
+ manifestJson.name = config.name();
+ }
+ if(config.packageName()) {
+ manifestJson.version = config.packageName();
+ }
+ if(config.description()) {
+ manifestJson.description = config.description();
+ }
+
+ if(config.author()) {
+ manifestJson.author = config.author();
+ }
+ }
--- End diff --
Should also add start url.
```
manifestJson.start_url = config.content();
```
I know the helper method content doesn't exist but getting the value of the
src attribute of the content tag should be pretty easy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
