GitHub user matrosov-nikita opened a pull request:

    https://github.com/apache/cordova-lib/pull/557

    CB-12787: Fix plugin installation with --link option

    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    all
    
    ### What does this PR do?
    Fix logic for installation plugins with `--link` option.
     - Use `npm link` instead of `npm install` during plugin fetch.
     - Find symbolic links in plugin's dir for plugin removal 
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosov-nikita/cordova-lib CB-12787

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/557.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #557
    
----
commit 0eb176af7f6b00984f3d41320a1ff6f7f494928c
Author: Nikita Matrosov <v-nim...@microsoft.com>
Date:   2017-05-12T11:26:05Z

    CB-12787: Fix plugin installation with --link option

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to